git/MetalOS
1
0
Fork 0
mirror of https://github.com/johndoe6345789/MetalOS.git synced 2026-04-24 13:45:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address code review feedback

Browse Source 
- Add comment about GLOB usage in kernel/CMakeLists.txt
- Improve clarity of optional screenshot capture in qemu-test.yml
- All code review comments addressed
- Security scan passed with 0 alerts

Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-28 20:42:52 +00:00
parent 1d0537c57a
commit 08fc016b8b
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/qemu-test.yml vendored
View File

@@ -76,7 +76,8 @@ jobs:
sleep 10
# Take screenshot using ImageMagick (optional - don't fail if this doesn't work)
import -window root build/qemu-screenshot.png || echo "Screenshot capture failed (non-fatal)"
# Using subshell to prevent 'set -e' from affecting this optional step
{ import -window root build/qemu-screenshot.png; } || echo "Screenshot capture failed (non-fatal)"
# Gracefully stop QEMU (don't fail if already stopped)
kill $QEMU_PID 2>/dev/null || true

2
kernel/CMakeLists.txt
View File

@@ -6,6 +6,8 @@ cmake_minimum_required(VERSION 3.16)
project(MetalOS_Kernel C ASM)
# Source files
# Note: Using GLOB for simplicity. For production, consider listing files explicitly.
# If new files aren't detected, re-run cmake configuration.
file(GLOB KERNEL_C_SOURCES "src/*.c")
file(GLOB KERNEL_ASM_SOURCES "src/*.asm")