From 08fc016b8bd8beafd516f06aafe2106fd9c09f7e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 28 Dec 2025 20:42:52 +0000 Subject: [PATCH] Address code review feedback - Add comment about GLOB usage in kernel/CMakeLists.txt - Improve clarity of optional screenshot capture in qemu-test.yml - All code review comments addressed - Security scan passed with 0 alerts Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com> --- .github/workflows/qemu-test.yml | 3 ++- kernel/CMakeLists.txt | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/qemu-test.yml b/.github/workflows/qemu-test.yml index 63ebffa..3a04184 100644 --- a/.github/workflows/qemu-test.yml +++ b/.github/workflows/qemu-test.yml @@ -76,7 +76,8 @@ jobs: sleep 10 # Take screenshot using ImageMagick (optional - don't fail if this doesn't work) - import -window root build/qemu-screenshot.png || echo "Screenshot capture failed (non-fatal)" + # Using subshell to prevent 'set -e' from affecting this optional step + { import -window root build/qemu-screenshot.png; } || echo "Screenshot capture failed (non-fatal)" # Gracefully stop QEMU (don't fail if already stopped) kill $QEMU_PID 2>/dev/null || true diff --git a/kernel/CMakeLists.txt b/kernel/CMakeLists.txt index 8fefe78..9c4d380 100644 --- a/kernel/CMakeLists.txt +++ b/kernel/CMakeLists.txt @@ -6,6 +6,8 @@ cmake_minimum_required(VERSION 3.16) project(MetalOS_Kernel C ASM) # Source files +# Note: Using GLOB for simplicity. For production, consider listing files explicitly. +# If new files aren't detected, re-run cmake configuration. file(GLOB KERNEL_C_SOURCES "src/*.c") file(GLOB KERNEL_ASM_SOURCES "src/*.asm")