git/GithubWorkflowTool
1
0
Fork 0
mirror of https://github.com/johndoe6345789/GithubWorkflowTool.git synced 2026-04-24 13:45:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address code review feedback: use modern C++ range-based loops

Browse Source 
- Use asKeyValueRange() for cleaner QMap iteration
- Use jobId from map key instead of job.id field
- Improve code readability and consistency

Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-27 03:27:38 +00:00
parent 1d20f8f295
commit 1cc26bfb97
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/cli/CommandHandler.cpp
View File

@@ -239,13 +239,12 @@ int CommandHandler::handleDoctor(const QStringList& args) {
// Check for job dependencies
bool hasValidDeps = true;
for (auto it = workflow.jobs.begin(); it != workflow.jobs.end(); ++it) {
const WorkflowJob& job = it.value();
for (const auto& [jobId, job] : workflow.jobs.asKeyValueRange()) {
if (!job.needs.isEmpty()) {
for (const QString& dep : job.needs) {
if (!workflow.jobs.contains(dep)) {
hasValidDeps = false;
out << "✗ Error: Job '" << job.id << "' depends on non-existent job '" << dep << "'" << Qt::endl;
out << "✗ Error: Job '" << jobId << "' depends on non-existent job '" << dep << "'" << Qt::endl;
errors++;
issues++;
}
@@ -255,8 +254,8 @@ int CommandHandler::handleDoctor(const QStringList& args) {
if (hasValidDeps && workflow.jobs.size() > 1) {
bool hasDeps = false;
for (auto it = workflow.jobs.begin(); it != workflow.jobs.end(); ++it) {
if (!it.value().needs.isEmpty()) {
for (const auto& [jobId, job] : workflow.jobs.asKeyValueRange()) {
if (!job.needs.isEmpty()) {
hasDeps = true;
break;
}