From 1cc26bfb97aea89aeebefd3ff3f34af57a7df19d Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 27 Dec 2025 03:27:38 +0000
Subject: [PATCH] Address code review feedback: use modern C++ range-based
 loops

- Use asKeyValueRange() for cleaner QMap iteration
- Use jobId from map key instead of job.id field
- Improve code readability and consistency

Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
---
 src/cli/CommandHandler.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/cli/CommandHandler.cpp b/src/cli/CommandHandler.cpp
index c919435..871f320 100644
--- a/src/cli/CommandHandler.cpp
+++ b/src/cli/CommandHandler.cpp
@@ -239,13 +239,12 @@ int CommandHandler::handleDoctor(const QStringList& args) {
             
             // Check for job dependencies
             bool hasValidDeps = true;
-            for (auto it = workflow.jobs.begin(); it != workflow.jobs.end(); ++it) {
-                const WorkflowJob& job = it.value();
+            for (const auto& [jobId, job] : workflow.jobs.asKeyValueRange()) {
                 if (!job.needs.isEmpty()) {
                     for (const QString& dep : job.needs) {
                         if (!workflow.jobs.contains(dep)) {
                             hasValidDeps = false;
-                            out << "✗ Error: Job '" << job.id << "' depends on non-existent job '" << dep << "'" << Qt::endl;
+                            out << "✗ Error: Job '" << jobId << "' depends on non-existent job '" << dep << "'" << Qt::endl;
                             errors++;
                             issues++;
                         }
@@ -255,8 +254,8 @@ int CommandHandler::handleDoctor(const QStringList& args) {
             
             if (hasValidDeps && workflow.jobs.size() > 1) {
                 bool hasDeps = false;
-                for (auto it = workflow.jobs.begin(); it != workflow.jobs.end(); ++it) {
-                    if (!it.value().needs.isEmpty()) {
+                for (const auto& [jobId, job] : workflow.jobs.asKeyValueRange()) {
+                    if (!job.needs.isEmpty()) {
                         hasDeps = true;
                         break;
                     }