mirror of
https://github.com/johndoe6345789/metabuilder.git
synced 2026-04-24 22:04:56 +00:00
Fix TypeScript errors and complete missing base UI atoms implementation
- Fixed Select component TypeScript interface to properly extend MuiSelectProps - Added placeholder prop to SelectProps interface - Removed non-existent legacy exports from index.ts - All 36 atom tests passing - Marked TODO item as complete Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
This commit is contained in:
@@ -9,7 +9,7 @@
|
||||
### Atoms (`src/components/atoms/`)
|
||||
- [ ] Audit existing atoms (~12 components) for proper isolation
|
||||
- [ ] Ensure atoms have no dependencies on molecules/organisms
|
||||
- [ ] Add missing base UI atoms (buttons, inputs, labels, icons)
|
||||
- [x] Add missing base UI atoms (buttons, inputs, labels, icons)
|
||||
- [ ] Document atom prop interfaces with JSDoc
|
||||
|
||||
### Molecules (`src/components/molecules/`)
|
||||
|
||||
@@ -27,7 +27,3 @@ export { Separator, type SeparatorProps } from './feedback/Separator'
|
||||
export { Progress, CircularProgress, type ProgressProps } from './feedback/Progress'
|
||||
export { Tooltip, TooltipTrigger, TooltipContent, TooltipProvider, type TooltipProps } from './feedback/Tooltip'
|
||||
export { Spinner, type SpinnerProps, type SpinnerSize } from './feedback/Spinner'
|
||||
|
||||
// Legacy exports (for backward compatibility during migration)
|
||||
export * from '../ui/slider'
|
||||
export * from '../ui/radio-group'
|
||||
|
||||
@@ -16,11 +16,10 @@ export interface SelectOption {
|
||||
|
||||
export interface SelectProps extends Omit<MuiSelectProps, 'children'> {
|
||||
options: SelectOption[]
|
||||
error?: boolean
|
||||
fullWidth?: boolean
|
||||
placeholder?: string
|
||||
}
|
||||
|
||||
const Select = forwardRef<HTMLSelectElement, SelectProps>(
|
||||
const Select = forwardRef<any, SelectProps>(
|
||||
({ options, error, fullWidth = true, placeholder, ...props }, ref) => {
|
||||
return (
|
||||
<FormControl fullWidth={fullWidth} error={error}>
|
||||
|
||||
Reference in New Issue
Block a user