git/metabuilder
1
0
Fork 0
mirror of https://github.com/johndoe6345789/metabuilder.git synced 2026-04-24 13:54:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1436 from johndoe6345789/copilot/fix-gate-2-1-unit-tests

Browse Source 
Fix 22 failing unit tests in Gate 2.1
This commit is contained in:
johndoe6345789
2026-01-08 18:08:00 +00:00
committed by GitHub
parent cddd61f3ef 7e3851c93b
commit 8e713e5ff8
4 changed files with 41 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
frontends/nextjs/src/lib/api/retry.test.ts
View File

@@ -20,9 +20,11 @@ describe('retry utilities', () => {
{ statusCode: 503, shouldRetry: true, description: 'service unavailable (retryable)' },
{ statusCode: 429, shouldRetry: true, description: 'rate limited (retryable)' },
])('should handle $description correctly', async ({ statusCode, shouldRetry }) => {
let callCount = 0
const mockFetch = vi.fn(async () => { // eslint-disable-line @typescript-eslint/require-await
const currentCall = callCount++
return new Response(JSON.stringify({ test: 'data' }), {
status: shouldRetry ? (mockFetch.mock.calls.length === 0 ? statusCode : 200) : statusCode,
status: shouldRetry ? (currentCall === 0 ? statusCode : 200) : statusCode,
})
})
@@ -112,9 +114,10 @@ describe('retry utilities', () => {
throw new Error('Network error')
})
const promise = retryFetch(mockFetch, { maxRetries: 2, initialDelayMs: 10 })
// Fast-forward through all retry delays
const promise = retryFetch(mockFetch, { maxRetries: 2, initialDelayMs: 10 })
// Attach a catch handler to prevent unhandled rejection warning
promise.catch(() => {})
await vi.advanceTimersByTimeAsync(500)
await expect(promise).rejects.toThrow('Network error')
@@ -180,8 +183,10 @@ describe('retry utilities', () => {
throw new Error('Persistent error')
})
// Fast-forward through all retry delays
const promise = retry(mockFn, { maxRetries: 2, initialDelayMs: 10 })
// Attach a catch handler to prevent unhandled rejection warning
promise.catch(() => {})
await vi.advanceTimersByTimeAsync(500)
await expect(promise).rejects.toThrow('Persistent error')

2
frontends/nextjs/src/lib/compiler/index.ts
View File

@@ -37,7 +37,7 @@ export async function compile(source: string, options?: CompileOptions): Promise
return {
code: result.code,
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition, @typescript-eslint/prefer-nullish-coalescing
map: (result.map !== null && result.map !== undefined) ? result.map : undefined,
map: (result.map !== null && result.map !== undefined && result.map !== '') ? result.map : undefined,
}
} catch (error) {
// Return compilation error as a comment in the code

35
frontends/nextjs/src/lib/entities/api-client.ts
View File

@@ -72,7 +72,12 @@ export async function fetchEntityList(
})
if (!response.ok) {
const errorData = await response.json().catch(() => ({ error: 'Unknown error' })) as { error?: string }
let errorData: { error?: string } = { error: 'Unknown error' }
try {
errorData = await response.json() as { error?: string }
} catch {
// If JSON parsing fails, use default error
}
return {
error: errorData.error ?? `HTTP ${response.status}`,
@@ -121,7 +126,12 @@ export async function fetchEntity(
})
if (!response.ok) {
const errorData = await response.json().catch(() => ({ error: 'Unknown error' })) as { error?: string }
let errorData: { error?: string } = { error: 'Unknown error' }
try {
errorData = await response.json() as { error?: string }
} catch {
// If JSON parsing fails, use default error
}
return {
error: errorData.error ?? `HTTP ${response.status}`,
@@ -172,7 +182,12 @@ export async function createEntity(
})
if (!response.ok) {
const errorData = await response.json().catch(() => ({ error: 'Unknown error' })) as { error?: string }
let errorData: { error?: string } = { error: 'Unknown error' }
try {
errorData = await response.json() as { error?: string }
} catch {
// If JSON parsing fails, use default error
}
return {
error: errorData.error ?? `HTTP ${response.status}`,
@@ -225,7 +240,12 @@ export async function updateEntity(
})
if (!response.ok) {
const errorData = await response.json().catch(() => ({ error: 'Unknown error' })) as { error?: string }
let errorData: { error?: string } = { error: 'Unknown error' }
try {
errorData = await response.json() as { error?: string }
} catch {
// If JSON parsing fails, use default error
}
return {
error: errorData.error ?? `HTTP ${response.status}`,
@@ -275,7 +295,12 @@ export async function deleteEntity(
})
if (!response.ok) {
const errorData = await response.json().catch(() => ({ error: 'Unknown error' })) as { error?: string }
let errorData: { error?: string } = { error: 'Unknown error' }
try {
errorData = await response.json() as { error?: string }
} catch {
// If JSON parsing fails, use default error
}
return {
error: errorData.error ?? `HTTP ${response.status}`,

2
frontends/nextjs/src/lib/middleware/auth-middleware.ts
View File

@@ -85,7 +85,7 @@ export async function authenticate(
const user = await getCurrentUser()
// Check if user is authenticated
if (user === null) {
if (user === null || user === undefined) {
return {
success: false,
error: NextResponse.json(