Refactor FeatureIdeaCloud to use shared hook

This commit is contained in:
2026-01-18 00:52:58 +00:00
parent 163b2b773d
commit 1e23c70972
2 changed files with 6 additions and 692 deletions

View File

@@ -1,693 +1,9 @@
import { useState, useEffect, useCallback, useRef } from 'react'
import { useKV } from '@/hooks/use-kv'
import ReactFlow, {
Node,
Edge,
Controls,
Background,
BackgroundVariant,
useNodesState,
useEdgesState,
Connection as RFConnection,
MarkerType,
ConnectionMode,
Panel,
reconnectEdge,
} from 'reactflow'
import 'reactflow/dist/style.css'
import { Button } from '@/components/ui/button'
import { Input } from '@/components/ui/input'
import { Textarea } from '@/components/ui/textarea'
import { Dialog, DialogContent, DialogHeader, DialogTitle, DialogDescription, DialogFooter } from '@/components/ui/dialog'
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip'
import { ScrollArea } from '@/components/ui/scroll-area'
import { Plus, Trash, Sparkle, Package } from '@phosphor-icons/react'
import { toast } from 'sonner'
import { FeatureIdea, IdeaGroup, IdeaEdgeData } from './FeatureIdeaCloud/types'
import { CONNECTION_STYLE } from './FeatureIdeaCloud/constants'
import seedIdeasData from './FeatureIdeaCloud/data/seed-ideas.json'
import categoriesData from './FeatureIdeaCloud/data/categories.json'
import prioritiesData from './FeatureIdeaCloud/data/priorities.json'
import statusesData from './FeatureIdeaCloud/data/statuses.json'
import groupColorsData from './FeatureIdeaCloud/data/group-colors.json'
import { nodeTypes } from './FeatureIdeaCloud/nodes'
import { dispatchConnectionCountUpdate } from './FeatureIdeaCloud/dispatchConnectionCountUpdate'
type SeedIdeaJson = Omit<FeatureIdea, 'createdAt'> & { createdAtOffsetMs: number }
const SEED_IDEAS: FeatureIdea[] = (seedIdeasData as SeedIdeaJson[]).map((idea) => {
const { createdAtOffsetMs, ...rest } = idea
return {
...rest,
createdAt: Date.now() - createdAtOffsetMs,
}
})
const CATEGORIES = categoriesData as string[]
const PRIORITIES = prioritiesData as FeatureIdea['priority'][]
const STATUSES = statusesData as FeatureIdea['status'][]
const GROUP_COLORS = groupColorsData as Array<{ name: string; value: string; bg: string; border: string }>
import { FeatureIdeaCanvas } from './FeatureIdeaCloud/FeatureIdeaCanvas'
import { FeatureIdeaDialogs } from './FeatureIdeaCloud/FeatureIdeaDialogs'
import { useFeatureIdeaCloud } from './FeatureIdeaCloud/useFeatureIdeaCloud'
export function FeatureIdeaCloud() {
const [ideas, setIdeas] = useKV<FeatureIdea[]>('feature-ideas', SEED_IDEAS)
const [groups, setGroups] = useKV<IdeaGroup[]>('feature-idea-groups', [])
const [savedEdges, setSavedEdges] = useKV<Edge<IdeaEdgeData>[]>('feature-idea-edges', [
{
id: 'edge-1',
source: 'idea-1',
target: 'idea-8',
sourceHandle: 'right-0',
targetHandle: 'left-0',
type: 'default',
animated: false,
data: { label: 'requires' },
markerEnd: { type: MarkerType.ArrowClosed, color: '#a78bfa', width: 20, height: 20 },
style: { stroke: '#a78bfa', strokeWidth: 2.5 },
},
{
id: 'edge-2',
source: 'idea-2',
target: 'idea-4',
sourceHandle: 'bottom-0',
targetHandle: 'top-0',
type: 'default',
data: { label: 'works with' },
markerEnd: { type: MarkerType.ArrowClosed, color: '#a78bfa', width: 20, height: 20 },
style: { stroke: '#a78bfa', strokeWidth: 2.5 },
},
{
id: 'edge-3',
source: 'idea-8',
target: 'idea-5',
sourceHandle: 'bottom-0',
targetHandle: 'left-0',
type: 'default',
data: { label: 'includes' },
markerEnd: { type: MarkerType.ArrowClosed, color: '#a78bfa', width: 20, height: 20 },
style: { stroke: '#a78bfa', strokeWidth: 2.5 },
},
])
const [savedNodePositions, setSavedNodePositions] = useKV<Record<string, { x: number; y: number }>>('feature-idea-node-positions', {})
const [nodes, setNodes, onNodesChange] = useNodesState([])
const [edges, setEdges, onEdgesChange] = useEdgesState([])
const [selectedIdea, setSelectedIdea] = useState<FeatureIdea | null>(null)
const [selectedGroup, setSelectedGroup] = useState<IdeaGroup | null>(null)
const [selectedEdge, setSelectedEdge] = useState<Edge<IdeaEdgeData> | null>(null)
const [editDialogOpen, setEditDialogOpen] = useState(false)
const [groupDialogOpen, setGroupDialogOpen] = useState(false)
const [viewDialogOpen, setViewDialogOpen] = useState(false)
const [edgeDialogOpen, setEdgeDialogOpen] = useState(false)
const [debugPanelOpen, setDebugPanelOpen] = useState(false)
const edgeReconnectSuccessful = useRef(true)
const safeIdeas = ideas || SEED_IDEAS
const safeGroups = groups || []
const safeEdges = savedEdges || []
const safeNodePositions = savedNodePositions || {}
const updateNodeConnectionCounts = useCallback((edges: Edge<IdeaEdgeData>[]) => {
const nodeConnectionMap = new Map<string, Record<string, Set<string>>>()
edges.forEach(edge => {
const sourceHandle = edge.sourceHandle || 'default'
const targetHandle = edge.targetHandle || 'default'
if (!nodeConnectionMap.has(edge.source)) {
nodeConnectionMap.set(edge.source, { left: new Set(), right: new Set(), top: new Set(), bottom: new Set() })
}
if (!nodeConnectionMap.has(edge.target)) {
nodeConnectionMap.set(edge.target, { left: new Set(), right: new Set(), top: new Set(), bottom: new Set() })
}
const sourceSide = sourceHandle.split('-')[0]
const targetSide = targetHandle.split('-')[0]
nodeConnectionMap.get(edge.source)![sourceSide].add(sourceHandle)
nodeConnectionMap.get(edge.target)![targetSide].add(targetHandle)
})
nodeConnectionMap.forEach((connections, nodeId) => {
const counts = {
left: connections.left.size,
right: connections.right.size,
top: connections.top.size,
bottom: connections.bottom.size,
}
dispatchConnectionCountUpdate(nodeId, counts)
})
}, [])
useEffect(() => {
if (!ideas || ideas.length === 0) {
setIdeas(SEED_IDEAS)
}
}, [ideas, setIdeas])
useEffect(() => {
const groupNodes: Node<IdeaGroup>[] = safeGroups.map((group) => ({
id: group.id,
type: 'groupNode',
position: safeNodePositions[group.id] || { x: 0, y: 0 },
data: group,
style: {
zIndex: -1,
},
}))
const ideaNodes: Node<FeatureIdea>[] = safeIdeas.map((idea, index) => ({
id: idea.id,
type: 'ideaNode',
position: safeNodePositions[idea.id] || { x: 100 + (index % 3) * 350, y: 100 + Math.floor(index / 3) * 250 },
data: idea,
parentNode: idea.parentGroup,
extent: idea.parentGroup ? 'parent' : undefined,
style: {
zIndex: 1,
},
}))
setNodes([...groupNodes, ...ideaNodes])
}, [safeIdeas, safeGroups, safeNodePositions, setNodes])
useEffect(() => {
setEdges(safeEdges)
updateNodeConnectionCounts(safeEdges)
}, [safeEdges, setEdges, updateNodeConnectionCounts])
useEffect(() => {
const handleEditIdea = (e: Event) => {
const customEvent = e as CustomEvent<FeatureIdea>
setSelectedIdea(customEvent.detail)
setEditDialogOpen(true)
}
const handleEditGroup = (e: Event) => {
const customEvent = e as CustomEvent<IdeaGroup>
setSelectedGroup(customEvent.detail)
setGroupDialogOpen(true)
}
window.addEventListener('editIdea', handleEditIdea)
window.addEventListener('editGroup', handleEditGroup)
return () => {
window.removeEventListener('editIdea', handleEditIdea)
window.removeEventListener('editGroup', handleEditGroup)
}
}, [])
const onNodesChangeWrapper = useCallback(
(changes: any) => {
onNodesChange(changes)
const moveChange = changes.find((c: any) => c.type === 'position' && c.dragging === false)
if (moveChange) {
setTimeout(() => {
setNodes((currentNodes) => {
const positions: Record<string, { x: number; y: number }> = {}
currentNodes.forEach(node => {
if (node.position) {
positions[node.id] = node.position
}
})
setSavedNodePositions(positions)
return currentNodes
})
setEdges((currentEdges) => {
setSavedEdges(currentEdges)
return currentEdges
})
}, 100)
}
},
[onNodesChange, setNodes, setEdges, setSavedNodePositions, setSavedEdges]
)
const onEdgesChangeWrapper = useCallback(
(changes: any) => {
onEdgesChange(changes)
setTimeout(() => {
setEdges((currentEdges) => {
setSavedEdges(currentEdges)
updateNodeConnectionCounts(currentEdges)
return currentEdges
})
}, 100)
},
[onEdgesChange, setEdges, setSavedEdges, updateNodeConnectionCounts]
)
const validateAndRemoveConflicts = useCallback((
edges: Edge<IdeaEdgeData>[],
sourceNodeId: string,
sourceHandleId: string,
targetNodeId: string,
targetHandleId: string,
excludeEdgeId?: string
): { filteredEdges: Edge<IdeaEdgeData>[], removedCount: number, conflicts: string[] } => {
const edgesToRemove: string[] = []
const conflicts: string[] = []
console.log('[Validator] Checking for conflicts:', {
newConnection: `${sourceNodeId}[${sourceHandleId}] -> ${targetNodeId}[${targetHandleId}]`,
existingEdges: edges.length,
excludeEdgeId
})
edges.forEach(edge => {
if (excludeEdgeId && edge.id === excludeEdgeId) {
console.log('[Validator] Skipping excluded edge:', edge.id)
return
}
const edgeSourceHandle = edge.sourceHandle || 'default'
const edgeTargetHandle = edge.targetHandle || 'default'
const hasSourceConflict = edge.source === sourceNodeId && edgeSourceHandle === sourceHandleId
const hasTargetConflict = edge.target === targetNodeId && edgeTargetHandle === targetHandleId
if (hasSourceConflict && !edgesToRemove.includes(edge.id)) {
edgesToRemove.push(edge.id)
conflicts.push(`Source: ${edge.source}[${edgeSourceHandle}] was connected to ${edge.target}[${edgeTargetHandle}]`)
console.log('[Validator] SOURCE CONFLICT DETECTED:', edge.id, edge)
}
if (hasTargetConflict && !edgesToRemove.includes(edge.id)) {
edgesToRemove.push(edge.id)
conflicts.push(`Target: ${edge.target}[${edgeTargetHandle}] was connected from ${edge.source}[${edgeSourceHandle}]`)
console.log('[Validator] TARGET CONFLICT DETECTED:', edge.id, edge)
}
})
const filteredEdges = edges.filter(e => !edgesToRemove.includes(e.id))
console.log('[Validator] Conflicts found:', conflicts.length, 'edges to remove:', edgesToRemove)
return {
filteredEdges,
removedCount: edgesToRemove.length,
conflicts
}
}, [])
const onConnect = useCallback(
(params: RFConnection) => {
if (!params.source || !params.target) return
const sourceNodeId = params.source
const sourceHandleId = params.sourceHandle || 'default'
const targetNodeId = params.target
const targetHandleId = params.targetHandle || 'default'
console.log('[Connection] ==== NEW CONNECTION ATTEMPT ====')
console.log('[Connection] Source:', `${sourceNodeId}[${sourceHandleId}]`)
console.log('[Connection] Target:', `${targetNodeId}[${targetHandleId}]`)
setEdges((eds) => {
console.log('[Connection] Current edges BEFORE validation:', eds.length)
eds.forEach(e => {
console.log(` - ${e.id}: ${e.source}[${e.sourceHandle || 'default'}] -> ${e.target}[${e.targetHandle || 'default'}]`)
})
const { filteredEdges, removedCount, conflicts } = validateAndRemoveConflicts(
eds,
sourceNodeId,
sourceHandleId,
targetNodeId,
targetHandleId
)
console.log('[Connection] Edges AFTER conflict removal:', filteredEdges.length)
const newEdge: Edge<IdeaEdgeData> = {
id: `edge-${Date.now()}`,
source: sourceNodeId,
target: targetNodeId,
sourceHandle: sourceHandleId,
targetHandle: targetHandleId,
type: 'default',
data: { label: 'relates to' },
markerEnd: {
type: MarkerType.ArrowClosed,
color: CONNECTION_STYLE.stroke,
width: 20,
height: 20
},
style: {
stroke: CONNECTION_STYLE.stroke,
strokeWidth: CONNECTION_STYLE.strokeWidth
},
animated: false,
}
console.log('[Connection] Creating new edge:', newEdge.id)
const updatedEdges = [...filteredEdges, newEdge]
console.log('[Connection] Total edges AFTER addition:', updatedEdges.length)
console.log('[Connection] Final edge list:')
updatedEdges.forEach(e => {
console.log(` - ${e.id}: ${e.source}[${e.sourceHandle || 'default'}] -> ${e.target}[${e.targetHandle || 'default'}]`)
})
setSavedEdges(updatedEdges)
updateNodeConnectionCounts(updatedEdges)
if (removedCount > 0) {
setTimeout(() => {
toast.success(`Connection remapped! (${removedCount} old connection${removedCount > 1 ? 's' : ''} removed)`, {
description: conflicts.join('\n')
})
}, 0)
} else {
setTimeout(() => {
toast.success('Ideas connected!')
}, 0)
}
return updatedEdges
})
},
[setEdges, setSavedEdges, validateAndRemoveConflicts, updateNodeConnectionCounts]
)
const onEdgeClick = useCallback((event: React.MouseEvent, edge: Edge<IdeaEdgeData>) => {
setSelectedEdge(edge)
setEdgeDialogOpen(true)
}, [])
const onNodeDoubleClick = useCallback((event: React.MouseEvent, node: Node<FeatureIdea>) => {
setSelectedIdea(node.data)
setViewDialogOpen(true)
}, [])
const onReconnectStart = useCallback(() => {
edgeReconnectSuccessful.current = false
}, [])
const onReconnect = useCallback((oldEdge: Edge, newConnection: RFConnection) => {
if (!newConnection.source || !newConnection.target) return
const sourceNodeId = newConnection.source
const sourceHandleId = newConnection.sourceHandle || 'default'
const targetNodeId = newConnection.target
const targetHandleId = newConnection.targetHandle || 'default'
console.log('[Reconnection] Remapping edge:', {
oldEdgeId: oldEdge.id,
oldSource: `${oldEdge.source}[${oldEdge.sourceHandle || 'default'}]`,
oldTarget: `${oldEdge.target}[${oldEdge.targetHandle || 'default'}]`,
newSource: `${sourceNodeId}[${sourceHandleId}]`,
newTarget: `${targetNodeId}[${targetHandleId}]`
})
edgeReconnectSuccessful.current = true
setEdges((els) => {
const { filteredEdges, removedCount, conflicts } = validateAndRemoveConflicts(
els,
sourceNodeId,
sourceHandleId,
targetNodeId,
targetHandleId,
oldEdge.id
)
const updatedEdges = reconnectEdge(oldEdge, newConnection, filteredEdges)
console.log('[Reconnection] Edge remapped successfully')
console.log('[Reconnection] Total edges after remapping:', updatedEdges.length)
console.log('[Reconnection] Edges by handle:', updatedEdges.map(e => ({
id: e.id,
source: `${e.source}[${e.sourceHandle || 'default'}]`,
target: `${e.target}[${e.targetHandle || 'default'}]`
})))
setSavedEdges(updatedEdges)
updateNodeConnectionCounts(updatedEdges)
if (removedCount > 0) {
setTimeout(() => {
toast.success(`Connection remapped! (${removedCount} conflicting connection${removedCount > 1 ? 's' : ''} removed)`, {
description: conflicts.join('\n')
})
}, 0)
} else {
setTimeout(() => {
toast.success('Connection remapped!')
}, 0)
}
return updatedEdges
})
}, [setEdges, setSavedEdges, validateAndRemoveConflicts, updateNodeConnectionCounts])
const onReconnectEnd = useCallback((_: MouseEvent | TouchEvent, edge: Edge) => {
if (!edgeReconnectSuccessful.current) {
setEdges((eds) => {
const updatedEdges = eds.filter((e) => e.id !== edge.id)
setSavedEdges(updatedEdges)
return updatedEdges
})
}
edgeReconnectSuccessful.current = true
}, [setEdges, setSavedEdges])
const handleAddIdea = () => {
const newIdea: FeatureIdea = {
id: `idea-${Date.now()}`,
title: '',
description: '',
category: 'Other',
priority: 'medium',
status: 'idea',
createdAt: Date.now(),
}
setSelectedIdea(newIdea)
setEditDialogOpen(true)
}
const handleAddGroup = () => {
const newGroup: IdeaGroup = {
id: `group-${Date.now()}`,
label: '',
color: GROUP_COLORS[0].value,
createdAt: Date.now(),
}
setSelectedGroup(newGroup)
setGroupDialogOpen(true)
}
const handleSaveIdea = () => {
if (!selectedIdea || !selectedIdea.title.trim()) {
toast.error('Please enter a title')
return
}
setIdeas((currentIdeas) => {
const existing = (currentIdeas || []).find(i => i.id === selectedIdea.id)
if (existing) {
return (currentIdeas || []).map(i => i.id === selectedIdea.id ? selectedIdea : i)
} else {
return [...(currentIdeas || []), selectedIdea]
}
})
if (!(ideas || []).find(i => i.id === selectedIdea.id)) {
const newPosition = { x: 400, y: 300 }
const newNode: Node<FeatureIdea> = {
id: selectedIdea.id,
type: 'ideaNode',
position: newPosition,
data: selectedIdea,
}
setNodes((nds) => [...nds, newNode])
setSavedNodePositions((currentPositions) => ({
...(currentPositions || {}),
[selectedIdea.id]: newPosition,
}))
}
setEditDialogOpen(false)
setSelectedIdea(null)
toast.success('Idea saved!')
}
const handleDeleteIdea = (id: string) => {
setIdeas((currentIdeas) => (currentIdeas || []).filter(i => i.id !== id))
setNodes((nds) => nds.filter(n => n.id !== id))
setSavedNodePositions((currentPositions) => {
const newPositions = { ...(currentPositions || {}) }
delete newPositions[id]
return newPositions
})
const updatedEdges = edges.filter(e => e.source !== id && e.target !== id)
setEdges(updatedEdges)
setSavedEdges(updatedEdges)
updateNodeConnectionCounts(updatedEdges)
setEditDialogOpen(false)
setViewDialogOpen(false)
setSelectedIdea(null)
toast.success('Idea deleted')
}
const handleSaveGroup = () => {
if (!selectedGroup || !selectedGroup.label.trim()) {
toast.error('Please enter a group name')
return
}
setGroups((currentGroups) => {
const existing = (currentGroups || []).find(g => g.id === selectedGroup.id)
if (existing) {
return (currentGroups || []).map(g => g.id === selectedGroup.id ? selectedGroup : g)
} else {
return [...(currentGroups || []), selectedGroup]
}
})
if (!(groups || []).find(g => g.id === selectedGroup.id)) {
const newPosition = { x: 200, y: 200 }
const newNode: Node<IdeaGroup> = {
id: selectedGroup.id,
type: 'groupNode',
position: newPosition,
data: selectedGroup,
style: {
zIndex: -1,
},
}
setNodes((nds) => [newNode, ...nds])
setSavedNodePositions((currentPositions) => ({
...(currentPositions || {}),
[selectedGroup.id]: newPosition,
}))
}
setGroupDialogOpen(false)
setSelectedGroup(null)
toast.success('Group saved!')
}
const handleDeleteGroup = (id: string) => {
setIdeas((currentIdeas) =>
(currentIdeas || []).map(idea =>
idea.parentGroup === id ? { ...idea, parentGroup: undefined } : idea
)
)
setGroups((currentGroups) => (currentGroups || []).filter(g => g.id !== id))
setNodes((nds) => nds.filter(n => n.id !== id))
setSavedNodePositions((currentPositions) => {
const newPositions = { ...(currentPositions || {}) }
delete newPositions[id]
return newPositions
})
setGroupDialogOpen(false)
setSelectedGroup(null)
toast.success('Group deleted')
}
const handleDeleteEdge = (edgeId: string) => {
const updatedEdges = edges.filter(e => e.id !== edgeId)
setEdges(updatedEdges)
setSavedEdges(updatedEdges)
updateNodeConnectionCounts(updatedEdges)
setEdgeDialogOpen(false)
setSelectedEdge(null)
toast.success('Connection removed')
}
const handleSaveEdge = () => {
if (selectedEdge) {
const updatedEdge = {
...selectedEdge,
data: selectedEdge.data,
markerEnd: {
type: MarkerType.ArrowClosed,
color: CONNECTION_STYLE.stroke,
width: 20,
height: 20
},
style: {
stroke: CONNECTION_STYLE.stroke,
strokeWidth: CONNECTION_STYLE.strokeWidth
},
animated: false,
}
const updatedEdges = edges.map(e => e.id === selectedEdge.id ? updatedEdge : e)
setEdges(updatedEdges)
setSavedEdges(updatedEdges)
setEdgeDialogOpen(false)
toast.success('Connection updated!')
}
}
const handleGenerateIdeas = async () => {
toast.info('Generating ideas with AI...')
try {
const categoryList = CATEGORIES.join('|')
const promptText = `Generate 3 innovative feature ideas for a low-code application builder. Each idea should be practical and valuable. Return as JSON with this structure:
{
"ideas": [
{
"title": "Feature Name",
"description": "Brief description",
"category": "${categoryList}",
"priority": "low|medium|high"
}
]
}`
const response = await window.spark.llm(promptText, 'gpt-4o-mini', true)
const result = JSON.parse(response)
if (result.ideas && Array.isArray(result.ideas)) {
const newIdeas: FeatureIdea[] = result.ideas.map((idea: any) => ({
id: `idea-ai-${Date.now()}-${Math.random()}`,
title: idea.title,
description: idea.description,
category: idea.category || 'Other',
priority: idea.priority || 'medium',
status: 'idea' as const,
createdAt: Date.now(),
}))
setIdeas((currentIdeas) => [...(currentIdeas || []), ...newIdeas])
const newPositions: Record<string, { x: number; y: number }> = {}
const newNodes: Node<FeatureIdea>[] = newIdeas.map((idea, index) => {
const position = { x: 400 + (index * 250), y: 300 + (index * 150) }
newPositions[idea.id] = position
return {
id: idea.id,
type: 'ideaNode',
position,
data: idea,
}
})
setNodes((nds) => [...nds, ...newNodes])
setSavedNodePositions((currentPositions) => ({
...(currentPositions || {}),
...newPositions,
}))
toast.success(`Generated ${newIdeas.length} new ideas!`)
}
} catch (error) {
console.error('Failed to generate ideas:', error)
toast.error('Failed to generate ideas')
}
}
const cloud = useFeatureIdeaCloud()
return (
<div className="h-full flex flex-col bg-gradient-to-br from-background via-muted/20 to-background">

View File

@@ -5,6 +5,7 @@ import { useKV } from '@/hooks/use-kv'
import { FeatureIdea, IdeaGroup, IdeaEdgeData } from './types'
import { CATEGORIES, CONNECTION_STYLE, GROUP_COLORS } from './constants'
import { buildSeedEdges, buildSeedIdeas } from './seed-data'
import { dispatchConnectionCountUpdate } from './dispatchConnectionCountUpdate'
type SeedRef = {
ideas: FeatureIdea[]
@@ -112,10 +113,7 @@ export const useFeatureIdeaCloud = (): FeatureIdeaCloudState => {
bottom: connections.bottom.size,
}
const event = new CustomEvent('updateConnectionCounts', {
detail: { nodeId, counts },
})
window.dispatchEvent(event)
dispatchConnectionCountUpdate(nodeId, counts)
})
}, [])