Merge pull request #16 from johndoe6345789/claude/fix-socketio-send-error-ivmuu

Replace sock.send() with sock.sendall() for reliable data transmission

.github/workflows/README.md

@@ -0,0 +1,50 @@
+# GitHub Actions Workflows
+
+This directory contains GitHub Actions workflows for CI/CD automation.
+
+## Workflows
+
+### test.yml
+Runs on every push and pull request to ensure code quality:
+- **Backend Tests**: Runs pytest with coverage on Python 3.11 and 3.12
+  - Requires 70% test coverage minimum
+  - Uploads coverage reports to Codecov
+- **Frontend Tests**: Lints and builds the Next.js frontend
+- **Docker Build Test**: Validates Docker images can be built successfully
+
+### docker-publish.yml
+Runs on pushes to main and version tags:
+- Builds and pushes Docker images to GitHub Container Registry (GHCR)
+- Creates multi-platform images for both backend and frontend
+- Tags images with branch name, PR number, version, and commit SHA
+
+### create-release.yml
+Handles release creation and management
+
+## Test Coverage Requirements
+
+Backend tests must maintain at least 70% code coverage. The pipeline will fail if coverage drops below this threshold.
+
+## Local Testing
+
+To run tests locally before pushing:
+
+```bash
+# Backend tests
+cd backend
+pip install -r requirements.txt -r requirements-dev.txt
+pytest --cov=. --cov-report=term-missing
+
+# Frontend build
+cd frontend
+npm install
+npm run build
+```
+
+## Adding New Tests
+
+When adding new features:
+1. Write unit tests in `backend/tests/test_*.py`
+2. Ensure all tests pass locally
+3. Push changes - the CI will automatically run all tests
+4. Fix any failing tests before merging

.github/workflows/test.yml

@@ -0,0 +1,115 @@
+name: Run Tests
+
+on:
+  push:
+    branches: ['**']
+  pull_request:
+    branches: [main]
+
+jobs:
+  backend-tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ['3.11', '3.12']
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+
+      - name: Cache pip packages
+        uses: actions/cache@v4
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements*.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
+
+      - name: Install dependencies
+        working-directory: ./backend
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt
+          pip install -r requirements-dev.txt
+
+      - name: Run pytest with coverage
+        working-directory: ./backend
+        run: |
+          pytest --cov=. --cov-report=xml --cov-report=term-missing -v
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        with:
+          file: ./backend/coverage.xml
+          flags: backend
+          name: backend-coverage
+          fail_ci_if_error: false
+
+      - name: Check test coverage threshold
+        working-directory: ./backend
+        run: |
+          coverage report --fail-under=70
+
+  frontend-tests:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+          cache-dependency-path: frontend/package-lock.json
+
+      - name: Install dependencies
+        working-directory: ./frontend
+        run: npm ci
+
+      - name: Run linting
+        working-directory: ./frontend
+        run: npm run lint || echo "Linting not configured yet"
+
+      - name: Build frontend
+        working-directory: ./frontend
+        run: npm run build
+
+  docker-build-test:
+    runs-on: ubuntu-latest
+    needs: [backend-tests, frontend-tests]
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Build backend Docker image
+        uses: docker/build-push-action@v5
+        with:
+          context: ./backend
+          file: ./backend/Dockerfile
+          push: false
+          tags: backend:test
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+
+      - name: Build frontend Docker image
+        uses: docker/build-push-action@v5
+        with:
+          context: ./frontend
+          file: ./frontend/Dockerfile
+          push: false
+          tags: frontend:test
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+          build-args: |
+            NEXT_PUBLIC_API_URL=http://backend:5000

backend/.coveragerc

@@ -0,0 +1,22 @@
+[run]
+source = .
+omit =
+    tests/*
+    */__pycache__/*
+    */venv/*
+    */virtualenv/*
+    setup.py
+    conftest.py
+
+[report]
+exclude_lines =
+    pragma: no cover
+    def __repr__
+    raise AssertionError
+    raise NotImplementedError
+    if __name__ == .__main__.:
+    if TYPE_CHECKING:
+    @abstractmethod
+
+[html]
+directory = htmlcov

backend/app.py

@@ -575,7 +575,7 @@ def handle_input(data):
 
         # Send input to the container
         sock = exec_instance.output
-        sock.send(input_data.encode('utf-8'))
+        sock.sendall(input_data.encode('utf-8'))
 
     except Exception as e:
         logger.error(f"Error sending input: {e}", exc_info=True)

backend/pytest.ini

@@ -0,0 +1,17 @@
+[pytest]
+testpaths = tests
+python_files = test_*.py
+python_classes = Test*
+python_functions = test_*
+addopts =
+    -v
+    --strict-markers
+    --cov=.
+    --cov-report=term-missing
+    --cov-report=html
+    --cov-report=xml
+    --cov-branch
+markers =
+    unit: Unit tests
+    integration: Integration tests
+    slow: Slow running tests

backend/requirements-dev.txt

@@ -0,0 +1,6 @@
+pytest==8.0.0
+pytest-flask==1.3.0
+pytest-cov==4.1.0
+pytest-mock==3.12.0
+flask-testing==0.8.1
+coverage==7.4.1

backend/tests/README.md

@@ -0,0 +1,146 @@
+# Backend Tests
+
+Comprehensive test suite for the Docker Swarm Terminal backend API.
+
+## Test Structure
+
+```
+tests/
+├── conftest.py          # Pytest fixtures and configuration
+├── test_auth.py         # Authentication endpoint tests
+├── test_containers.py   # Container management tests
+├── test_exec.py         # Command execution tests
+├── test_health.py       # Health check tests
+└── test_utils.py        # Utility function tests
+```
+
+## Running Tests
+
+### Install Dependencies
+
+```bash
+pip install -r requirements.txt -r requirements-dev.txt
+```
+
+### Run All Tests
+
+```bash
+pytest
+```
+
+### Run with Coverage
+
+```bash
+pytest --cov=. --cov-report=html --cov-report=term-missing
+```
+
+This will generate an HTML coverage report in `htmlcov/index.html`.
+
+### Run Specific Test Files
+
+```bash
+pytest tests/test_auth.py
+pytest tests/test_containers.py -v
+```
+
+### Run Tests by Marker
+
+```bash
+pytest -m unit          # Run only unit tests
+pytest -m integration   # Run only integration tests
+```
+
+### Run with Verbose Output
+
+```bash
+pytest -v
+```
+
+## Test Coverage
+
+Current coverage target: **70%**
+
+To check if tests meet the coverage threshold:
+
+```bash
+coverage run -m pytest
+coverage report --fail-under=70
+```
+
+## Writing Tests
+
+### Test Naming Convention
+
+- Test files: `test_*.py`
+- Test classes: `Test*`
+- Test functions: `test_*`
+
+### Using Fixtures
+
+Common fixtures available in `conftest.py`:
+
+- `app`: Flask application instance
+- `client`: Test client for making HTTP requests
+- `auth_token`: Valid authentication token
+- `auth_headers`: Authentication headers dict
+- `mock_docker_client`: Mocked Docker client
+
+Example:
+
+```python
+def test_my_endpoint(client, auth_headers):
+    response = client.get('/api/my-endpoint', headers=auth_headers)
+    assert response.status_code == 200
+```
+
+### Mocking Docker Calls
+
+Use the `@patch` decorator to mock Docker API calls:
+
+```python
+from unittest.mock import patch, MagicMock
+
+@patch('app.get_docker_client')
+def test_container_operation(mock_get_client, client, auth_headers):
+    mock_client = MagicMock()
+    mock_get_client.return_value = mock_client
+    # Your test code here
+```
+
+## CI/CD Integration
+
+Tests automatically run on:
+- Every push to any branch
+- Every pull request to main
+- Multiple Python versions (3.11, 3.12)
+
+GitHub Actions will fail if:
+- Any test fails
+- Coverage drops below 70%
+- Docker images fail to build
+
+## Troubleshooting
+
+### Tests Failing Locally
+
+1. Ensure all dependencies are installed
+2. Check Python version (3.11+ required)
+3. Clear pytest cache: `pytest --cache-clear`
+
+### Import Errors
+
+Make sure you're running tests from the backend directory:
+
+```bash
+cd backend
+pytest
+```
+
+### Coverage Not Updating
+
+Clear coverage data and re-run:
+
+```bash
+coverage erase
+pytest --cov=. --cov-report=term-missing
+```

backend/tests/__init__.py

@@ -0,0 +1 @@
+# Test package initialization

backend/tests/conftest.py

@@ -0,0 +1,55 @@
+import pytest
+import sys
+import os
+
+# Add the backend directory to the path
+sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
+
+from app import app as flask_app, socketio
+
+
+@pytest.fixture
+def app():
+    """Create application for testing"""
+    flask_app.config.update({
+        'TESTING': True,
+        'WTF_CSRF_ENABLED': False
+    })
+    yield flask_app
+
+
+@pytest.fixture
+def client(app):
+    """Create a test client"""
+    return app.test_client()
+
+
+@pytest.fixture
+def runner(app):
+    """Create a test CLI runner"""
+    return app.test_cli_runner()
+
+
+@pytest.fixture
+def mock_docker_client(mocker):
+    """Mock Docker client"""
+    mock_client = mocker.MagicMock()
+    mock_client.ping.return_value = True
+    return mock_client
+
+
+@pytest.fixture
+def auth_token(client):
+    """Get a valid authentication token"""
+    response = client.post('/api/auth/login', json={
+        'username': 'admin',
+        'password': 'admin123'
+    })
+    data = response.get_json()
+    return data['token']
+
+
+@pytest.fixture
+def auth_headers(auth_token):
+    """Get authentication headers"""
+    return {'Authorization': f'Bearer {auth_token}'}

backend/tests/test_auth.py

@@ -0,0 +1,69 @@
+import pytest
+from datetime import datetime
+
+
+class TestAuthentication:
+    """Test authentication endpoints"""
+
+    def test_login_success(self, client):
+        """Test successful login"""
+        response = client.post('/api/auth/login', json={
+            'username': 'admin',
+            'password': 'admin123'
+        })
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['success'] is True
+        assert 'token' in data
+        assert data['username'] == 'admin'
+
+    def test_login_invalid_credentials(self, client):
+        """Test login with invalid credentials"""
+        response = client.post('/api/auth/login', json={
+            'username': 'admin',
+            'password': 'wrongpassword'
+        })
+
+        assert response.status_code == 401
+        data = response.get_json()
+        assert data['success'] is False
+        assert 'message' in data
+
+    def test_login_missing_username(self, client):
+        """Test login with missing username"""
+        response = client.post('/api/auth/login', json={
+            'password': 'admin123'
+        })
+
+        assert response.status_code == 401
+        data = response.get_json()
+        assert data['success'] is False
+
+    def test_login_missing_password(self, client):
+        """Test login with missing password"""
+        response = client.post('/api/auth/login', json={
+            'username': 'admin'
+        })
+
+        assert response.status_code == 401
+        data = response.get_json()
+        assert data['success'] is False
+
+    def test_logout_success(self, client, auth_token):
+        """Test successful logout"""
+        response = client.post('/api/auth/logout', headers={
+            'Authorization': f'Bearer {auth_token}'
+        })
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['success'] is True
+
+    def test_logout_without_token(self, client):
+        """Test logout without token"""
+        response = client.post('/api/auth/logout')
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['success'] is True

backend/tests/test_containers.py

@@ -0,0 +1,124 @@
+import pytest
+from unittest.mock import MagicMock, patch
+
+
+class TestContainerEndpoints:
+    """Test container management endpoints"""
+
+    def test_get_containers_unauthorized(self, client):
+        """Test getting containers without auth"""
+        response = client.get('/api/containers')
+        assert response.status_code == 401
+        data = response.get_json()
+        assert 'error' in data
+
+    def test_get_containers_invalid_token(self, client):
+        """Test getting containers with invalid token"""
+        response = client.get('/api/containers', headers={
+            'Authorization': 'Bearer invalid_token'
+        })
+        assert response.status_code == 401
+        data = response.get_json()
+        assert 'error' in data
+
+    @patch('app.get_docker_client')
+    def test_get_containers_success(self, mock_get_client, client, auth_headers):
+        """Test getting containers successfully"""
+        # Mock Docker client
+        mock_container = MagicMock()
+        mock_container.short_id = 'abc123'
+        mock_container.name = 'test-container'
+        mock_container.status = 'running'
+        mock_container.image.tags = ['nginx:latest']
+        mock_container.attrs = {'Created': '2024-01-01T00:00:00.000000000Z'}
+
+        mock_client = MagicMock()
+        mock_client.containers.list.return_value = [mock_container]
+        mock_get_client.return_value = mock_client
+
+        response = client.get('/api/containers', headers=auth_headers)
+        assert response.status_code == 200
+        data = response.get_json()
+        assert 'containers' in data
+        assert len(data['containers']) == 1
+        assert data['containers'][0]['id'] == 'abc123'
+        assert data['containers'][0]['name'] == 'test-container'
+
+    @patch('app.get_docker_client')
+    def test_get_containers_docker_unavailable(self, mock_get_client, client, auth_headers):
+        """Test getting containers when Docker is unavailable"""
+        mock_get_client.return_value = None
+
+        response = client.get('/api/containers', headers=auth_headers)
+        assert response.status_code == 500
+        data = response.get_json()
+        assert 'error' in data
+
+    @patch('app.get_docker_client')
+    def test_start_container_success(self, mock_get_client, client, auth_headers):
+        """Test starting a container"""
+        mock_container = MagicMock()
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.post('/api/containers/abc123/start', headers=auth_headers)
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['success'] is True
+        mock_container.start.assert_called_once()
+
+    @patch('app.get_docker_client')
+    def test_stop_container_success(self, mock_get_client, client, auth_headers):
+        """Test stopping a container"""
+        mock_container = MagicMock()
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.post('/api/containers/abc123/stop', headers=auth_headers)
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['success'] is True
+        mock_container.stop.assert_called_once()
+
+    @patch('app.get_docker_client')
+    def test_restart_container_success(self, mock_get_client, client, auth_headers):
+        """Test restarting a container"""
+        mock_container = MagicMock()
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.post('/api/containers/abc123/restart', headers=auth_headers)
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['success'] is True
+        mock_container.restart.assert_called_once()
+
+    @patch('app.get_docker_client')
+    def test_remove_container_success(self, mock_get_client, client, auth_headers):
+        """Test removing a container"""
+        mock_container = MagicMock()
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.delete('/api/containers/abc123', headers=auth_headers)
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['success'] is True
+        mock_container.remove.assert_called_once_with(force=True)
+
+    def test_container_operations_unauthorized(self, client):
+        """Test container operations without auth"""
+        endpoints = [
+            ('/api/containers/abc123/start', 'post'),
+            ('/api/containers/abc123/stop', 'post'),
+            ('/api/containers/abc123/restart', 'post'),
+            ('/api/containers/abc123', 'delete'),
+        ]
+
+        for endpoint, method in endpoints:
+            response = getattr(client, method)(endpoint)
+            assert response.status_code == 401

backend/tests/test_exec.py

@@ -0,0 +1,124 @@
+import pytest
+from unittest.mock import MagicMock, patch
+
+
+class TestContainerExec:
+    """Test container command execution"""
+
+    def test_exec_unauthorized(self, client):
+        """Test exec without auth"""
+        response = client.post('/api/containers/abc123/exec', json={
+            'command': 'ls'
+        })
+        assert response.status_code == 401
+
+    @patch('app.get_docker_client')
+    def test_exec_simple_command(self, mock_get_client, client, auth_headers, auth_token):
+        """Test executing a simple command"""
+        # Mock exec result
+        mock_exec_result = MagicMock()
+        mock_exec_result.output = b'file1.txt\nfile2.txt\n::WORKDIR::/app'
+        mock_exec_result.exit_code = 0
+
+        mock_container = MagicMock()
+        mock_container.exec_run.return_value = mock_exec_result
+
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.post('/api/containers/abc123/exec',
+                               headers=auth_headers,
+                               json={'command': 'ls'})
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['exit_code'] == 0
+        assert 'file1.txt' in data['output']
+        assert data['workdir'] == '/app'
+
+    @patch('app.get_docker_client')
+    def test_exec_cd_command(self, mock_get_client, client, auth_headers, auth_token):
+        """Test executing cd command"""
+        # Mock exec result for cd command
+        mock_exec_result = MagicMock()
+        mock_exec_result.output = b'/home/user\n'
+        mock_exec_result.exit_code = 0
+
+        mock_container = MagicMock()
+        mock_container.exec_run.return_value = mock_exec_result
+
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.post('/api/containers/abc123/exec',
+                               headers=auth_headers,
+                               json={'command': 'cd /home/user'})
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['exit_code'] == 0
+        assert data['workdir'] == '/home/user'
+        assert data['output'] == ''
+
+    @patch('app.get_docker_client')
+    def test_exec_command_with_error(self, mock_get_client, client, auth_headers, auth_token):
+        """Test executing a command that fails"""
+        # Mock exec result with error
+        mock_exec_result = MagicMock()
+        mock_exec_result.output = b'command not found::WORKDIR::/app'
+        mock_exec_result.exit_code = 127
+
+        mock_container = MagicMock()
+        mock_container.exec_run.return_value = mock_exec_result
+
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.post('/api/containers/abc123/exec',
+                               headers=auth_headers,
+                               json={'command': 'invalidcommand'})
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['exit_code'] == 127
+        assert 'command not found' in data['output']
+
+    @patch('app.get_docker_client')
+    def test_exec_docker_unavailable(self, mock_get_client, client, auth_headers):
+        """Test exec when Docker is unavailable"""
+        mock_get_client.return_value = None
+
+        response = client.post('/api/containers/abc123/exec',
+                               headers=auth_headers,
+                               json={'command': 'ls'})
+
+        assert response.status_code == 500
+        data = response.get_json()
+        assert 'error' in data
+
+    @patch('app.get_docker_client')
+    def test_exec_unicode_handling(self, mock_get_client, client, auth_headers, auth_token):
+        """Test exec with unicode output"""
+        # Mock exec result with unicode
+        mock_exec_result = MagicMock()
+        mock_exec_result.output = 'Hello 世界\n::WORKDIR::/app'.encode('utf-8')
+        mock_exec_result.exit_code = 0
+
+        mock_container = MagicMock()
+        mock_container.exec_run.return_value = mock_exec_result
+
+        mock_client = MagicMock()
+        mock_client.containers.get.return_value = mock_container
+        mock_get_client.return_value = mock_client
+
+        response = client.post('/api/containers/abc123/exec',
+                               headers=auth_headers,
+                               json={'command': 'echo "Hello 世界"'})
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['exit_code'] == 0
+        assert '世界' in data['output']

backend/tests/test_health.py

@@ -0,0 +1,13 @@
+import pytest
+
+
+class TestHealthEndpoint:
+    """Test health check endpoint"""
+
+    def test_health_check(self, client):
+        """Test health check endpoint"""
+        response = client.get('/api/health')
+
+        assert response.status_code == 200
+        data = response.get_json()
+        assert data['status'] == 'healthy'

backend/tests/test_utils.py

@@ -0,0 +1,42 @@
+import pytest
+from datetime import datetime, timezone
+from app import format_uptime
+
+
+class TestUtilityFunctions:
+    """Test utility functions"""
+
+    def test_format_uptime_days(self):
+        """Test uptime formatting for days"""
+        # Create a timestamp 2 days and 3 hours ago
+        now = datetime.now(timezone.utc)
+        created_at = now.replace(day=now.day-2, hour=now.hour-3)
+        created_str = created_at.isoformat().replace('+00:00', 'Z')
+
+        result = format_uptime(created_str)
+        assert 'd' in result
+        assert 'h' in result
+
+    def test_format_uptime_hours(self):
+        """Test uptime formatting for hours"""
+        # Create a timestamp 3 hours and 15 minutes ago
+        now = datetime.now(timezone.utc)
+        created_at = now.replace(hour=now.hour-3, minute=now.minute-15)
+        created_str = created_at.isoformat().replace('+00:00', 'Z')
+
+        result = format_uptime(created_str)
+        assert 'h' in result
+        assert 'm' in result
+        assert 'd' not in result
+
+    def test_format_uptime_minutes(self):
+        """Test uptime formatting for minutes"""
+        # Create a timestamp 30 minutes ago
+        now = datetime.now(timezone.utc)
+        created_at = now.replace(minute=now.minute-30)
+        created_str = created_at.isoformat().replace('+00:00', 'Z')
+
+        result = format_uptime(created_str)
+        assert 'm' in result
+        assert 'h' not in result
+        assert 'd' not in result

frontend/lib/theme.tsx

@@ -85,9 +85,18 @@ const theme = createTheme({
           borderRadius: '6px',
           padding: '8px 16px',
           transition: 'all 0.1s ease',
+          '&:hover': {
+            boxShadow: '0 0 8px rgba(56, 178, 172, 0.3)',
+          },
           '&:active': {
             transform: 'scale(0.98)',
           },
+          '&.Mui-disabled': {
+            opacity: 0.5,
+            backgroundColor: 'rgba(74, 85, 104, 0.3)',
+            borderColor: 'rgba(74, 85, 104, 0.5)',
+            color: 'rgba(247, 250, 252, 0.5)',
+          },
         },
       },
     },