git/SDL3CPlusPlus
1
0
Fork 0
mirror of https://github.com/johndoe6345789/SDL3CPlusPlus.git synced 2026-04-24 21:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Replace logging with ILogger in BeginFrame and RecordCommands for consistency

Browse Source
This commit is contained in:
johndoe6345789
2026-01-04 14:49:24 +00:00
parent ac35dd42eb
commit 4feab709a2
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/services/impl/render_command_service.cpp
View File

@@ -27,14 +27,14 @@ void RenderCommandService::Shutdown() noexcept {
}
bool RenderCommandService::BeginFrame(uint32_t& imageIndex) {
logging::TraceGuard trace;
logger_->TraceFunction(__func__);
// Lazy initialization
if (commandPool_ == VK_NULL_HANDLE) {
CreateCommandPool();
CreateCommandBuffers();
CreateSyncObjects();
logging::Logger::GetInstance().Info("RenderCommandService initialized lazily");
logger_->Info("RenderCommandService initialized lazily");
}
auto device = deviceService_->GetDevice();
@@ -44,10 +44,10 @@ bool RenderCommandService::BeginFrame(uint32_t& imageIndex) {
VkResult fenceResult = vkWaitForFences(device, 1, &inFlightFence_, VK_TRUE, kFenceTimeout);
if (fenceResult == VK_TIMEOUT) {
logging::Logger::GetInstance().Error("Fence wait timeout: GPU appears to be hung");
logger_->Error("Fence wait timeout: GPU appears to be hung");
throw std::runtime_error("Fence wait timeout: GPU appears to be hung");
} else if (fenceResult != VK_SUCCESS) {
logging::Logger::GetInstance().Error("Fence wait failed");
logger_->Error("Fence wait failed");
throw std::runtime_error("Fence wait failed");
}
@@ -59,7 +59,7 @@ bool RenderCommandService::BeginFrame(uint32_t& imageIndex) {
if (result == VK_ERROR_OUT_OF_DATE_KHR || result == VK_SUBOPTIMAL_KHR) {
return false; // Need swapchain recreation
} else if (result == VK_TIMEOUT) {
logging::Logger::GetInstance().Error("Image acquisition timeout");
logger_->Error("Image acquisition timeout");
throw std::runtime_error("Image acquisition timeout: GPU appears to be hung");
} else if (result != VK_SUCCESS) {
throw std::runtime_error("Failed to acquire swap chain image");
@@ -71,7 +71,7 @@ bool RenderCommandService::BeginFrame(uint32_t& imageIndex) {
void RenderCommandService::RecordCommands(uint32_t imageIndex,
const std::vector<RenderCommand>& commands,
const std::array<float, 16>& viewProj) {
logging::TraceGuard trace;
logger_->TraceFunction(__func__);
VkCommandBuffer commandBuffer = commandBuffers_[imageIndex];