git/SDL3CPlusPlus
1
0
Fork 0
mirror of https://github.com/johndoe6345789/SDL3CPlusPlus.git synced 2026-04-24 21:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Add SDL initialization in SdlWindowService to ensure proper setup before window creation

Browse Source
This commit is contained in:
johndoe6345789
2026-01-04 13:55:43 +00:00
parent 92cec63072
commit 3903168a46
2 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/app/service_based_app.cpp
View File

@@ -151,13 +151,13 @@ void ServiceBasedApp::RegisterServices() {
registry_.GetService<services::IVulkanDeviceService>(),
registry_.GetService<services::ISwapchainService>());
// Graphics service (facade)
registry_.RegisterService<services::IGraphicsService, services::impl::GraphicsService>(
registry_.GetService<services::IVulkanDeviceService>(),
registry_.GetService<services::ISwapchainService>(),
registry_.GetService<services::IPipelineService>(),
registry_.GetService<services::IBufferService>(),
registry_.GetService<services::IRenderCommandService>());
// Graphics service (facade) - temporarily disabled
// registry_.RegisterService<services::IGraphicsService, services::impl::GraphicsService>(
// registry_.GetService<services::IVulkanDeviceService>(),
// registry_.GetService<services::ISwapchainService>(),
// registry_.GetService<services::IPipelineService>(),
// registry_.GetService<services::IBufferService>(),
// registry_.GetService<services::IRenderCommandService>());
// Script service
registry_.RegisterService<services::IScriptService, services::impl::LuaScriptService>(scriptPath_);

19
src/services/impl/sdl_window_service.cpp
View File

@@ -98,6 +98,25 @@ void SdlWindowService::CreateWindow(const WindowConfig& config) {
throw std::runtime_error("Window already created");
}
// Initialize SDL here if not already initialized
if (SDL_WasInit(0) == 0) {
try {
ThrowSdlErrorIfFailed(SDL_Init(SDL_INIT_VIDEO | SDL_INIT_AUDIO), "SDL_Init failed");
} catch (const std::exception& e) {
ShowErrorDialog("SDL Initialization Failed",
std::string("Failed to initialize SDL subsystems.\n\nError: ") + e.what());
throw;
}
try {
ThrowSdlErrorIfFailed(SDL_Vulkan_LoadLibrary(nullptr), "SDL_Vulkan_LoadLibrary failed");
} catch (const std::exception& e) {
ShowErrorDialog("Vulkan Library Load Failed",
std::string("Failed to load Vulkan library. Make sure Vulkan drivers are installed.\n\nError: ") + e.what());
throw;
}
}
uint32_t flags = SDL_WINDOW_VULKAN;
if (config.resizable) {
flags |= SDL_WINDOW_RESIZABLE;