git/MetalOS
1
0
Fork 0
mirror of https://github.com/johndoe6345789/MetalOS.git synced 2026-04-24 13:45:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address code review feedback - improve comments and error handling

Browse Source 
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-28 18:33:38 +00:00
parent bab922bcd0
commit 68dc3a0767
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Makefile
View File

@@ -12,11 +12,11 @@ test:
bootloader:
@echo "Building bootloader..."
@cd bootloader && $(MAKE) || echo "Warning: Bootloader build failed (expected in early development)"
@cd bootloader && $(MAKE) || echo "Warning: Bootloader build failed (expected during Phase 1 development)"
kernel:
@echo "Building kernel..."
@cd kernel && $(MAKE) || echo "Warning: Kernel build failed (expected in early development)"
@cd kernel && $(MAKE) || echo "Warning: Kernel build failed (expected during Phase 1 development)"
# Create bootable disk image for UEFI/QEMU
image: bootloader kernel

13
scripts/create_image.sh
View File

@@ -15,16 +15,21 @@ if [ ! -f "bootloader/bootx64.efi" ]; then
echo "Warning: bootloader/bootx64.efi not found."
echo "Creating placeholder bootloader for testing..."
mkdir -p bootloader
# Create a minimal placeholder EFI file
echo "Placeholder UEFI bootloader" > bootloader/bootx64.efi
# NOTE: This creates a text placeholder, NOT a valid EFI executable.
# UEFI firmware will fail to execute it, but the image structure will be correct.
# This is intentional during early development (Phase 1).
# In Phase 2+, a proper UEFI bootloader will be built.
echo "Placeholder UEFI bootloader - not executable" > bootloader/bootx64.efi
fi
if [ ! -f "kernel/metalos.bin" ]; then
echo "Warning: kernel/metalos.bin not found."
echo "Creating placeholder kernel for testing..."
mkdir -p kernel
# Create a minimal placeholder kernel
echo "Placeholder kernel" > kernel/metalos.bin
# NOTE: This creates a text placeholder, NOT a valid kernel binary.
# This is intentional during early development (Phase 1).
# In Phase 3+, a proper kernel binary will be built.
echo "Placeholder kernel - not executable" > kernel/metalos.bin
fi
# Create directories