|
|
2125e5efe7
|
chore: Code review - fix critical bugs and lint errors
Key changes:
1. Fix critical bug in src/app/page.tsx: removed conflicting `export const dynamic` that shadowed imported `dynamic` from next/dynamic, causing ReferenceError at runtime. Replaced with `export const revalidate = 0` then removed (client component).
2. Install missing typescript-eslint dependency and fix ESLint configuration to use flat config format properly.
3. Fix 32 ESLint errors across codebase:
- Remove unused variables and imports (concat unused props in components)
- Replace `any` types with proper TypeScript types (React.MutableRefObject)
- Change empty interface in textarea.tsx to type alias
- Fix react-hooks rule name from non-existent `set-state-in-effect` to `exhaustive-deps`
4. Code quality improvements:
- Removed unused cn import from aspect-ratio.tsx
- Removed unused useRef, useEffect from sheet.tsx imports
- Simplified handler parameters in avatar.tsx
- Cleaned up test files (removed unused container/user variables)
Results after review:
- Unit tests: 275 passing, 14 failing (improved from 270/19)
- E2E tests: 204 passing, 59 failing, 17 skipped (now running after critical fix)
- Linter: 0 errors (all 32 fixed)
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
2026-01-20 19:07:14 +00:00 |
|
