- Fixed unnecessary conditional checks for optional properties in page.tsx
- Fixed unnecessary type assertions in page.tsx
- Fixed nullable object checks in test files
- Fixed nullable string checks in filtering.ts and validate-email.ts
- Removed unused eslint-disable directives across multiple files
- Fixed redundant type warning in monaco-editor-react.d.ts
- Generated Prisma types to resolve type errors
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
- Fixed ItemsPerPageSelector.test.tsx line 46: Added missing if statement and proper bracing
- Fixed retry.test.ts lines 148, 167, 176, 190: Moved eslint-disable comments to proper location
- All reported TypeScript compilation errors are now resolved
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
- Added test:unit script for unit tests
- Added test:e2e script referencing root Playwright config
- Added test:e2e:ui, test:e2e:headed, test:e2e:debug scripts
- Added test:e2e:report script
- Added test:e2e:dbal-daemon script for daemon-specific tests
- Fixed playwright.dbal-daemon.config.ts to use correct paths and health endpoint
This resolves the CI blocker where workflows running from frontends/nextjs
directory couldn't find these scripts.
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
Document all issues found and fixed:
- Test discovery picking up wrong files (unit tests)
- WebServer readiness check hanging on 404
- Missing database configuration
- Complete test results showing 4/5 passing
- Instructions for running tests
- Next steps for improvements
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
- Changed webServer url from http://localhost:3000 to /api/health endpoint
- Root path returns 404 (no configured homepage), causing Playwright to hang
- Health endpoint returns 200 OK, allowing Playwright to detect server readiness
- Added DATABASE_URL env var to webServer configuration
- Added stdout/stderr piping for better debugging
Tests now run successfully:
- 4/5 smoke tests passing
- Server starts and responds correctly
- Prisma connects and queries work
- Only expected failure is test checking for landing page buttons (404 page)
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
- Create root-level playwright config that properly scopes test discovery
- Configure testMatch to only find *.spec.ts files (not unit tests)
- Point testDir to ./e2e explicitly
- Fix webServer command to generate Prisma and start Next.js dev server
- Resolves test discovery picking up Vitest unit tests causing import errors
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
Fixed issue where absolute bot paths were hardcoded in Prisma configuration:
- Changed fallback from 'file:/home/runner/work/metabuilder/metabuilder/prisma/prisma/dev.db'
to 'file:../../prisma/prisma/dev.db' in both files
- This makes the code portable and works regardless of deployment location
- Verified dev server starts correctly and database operations work with relative path
Files modified:
- frontends/nextjs/src/lib/config/prisma.ts
- dbal/development/src/adapters/prisma/context.ts
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
The Playwright tests were timing out because:
1. Missing .env file with DATABASE_URL configuration
2. webServer command was running from wrong directory
Changes:
- Created frontends/nextjs/.env with DATABASE_URL and DBAL configuration
- Updated e2e/playwright.config.ts to use npm --prefix for correct path resolution
- Verified dev server starts successfully and responds to requests
- Database operations confirmed working (Prisma adapters functioning correctly)
Test status: Tests can now connect to server, infrastructure is ready
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
