git/metabuilder
1
0
Fork 0
mirror of https://github.com/johndoe6345789/metabuilder.git synced 2026-05-03 02:04:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address code review feedback - fix race condition, add size_t validation, improve tests

Browse Source 
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-25 08:34:14 +00:00
parent be863235a1
commit b7008427f9
2 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dbal/cpp/src/daemon/server.cpp
+11 -3
View File
@@ -275,14 +275,15 @@ private:
}
// Check connection limit to prevent thread exhaustion DoS
if (active_connections_.load() >= MAX_CONCURRENT_CONNECTIONS) {
// Use atomic fetch_add to avoid race condition
size_t prev_count = active_connections_.fetch_add(1);
if (prev_count >= MAX_CONCURRENT_CONNECTIONS) {
std::cerr << "Connection limit reached, rejecting connection" << std::endl;
active_connections_--;
CLOSE_SOCKET(client_fd);
continue;
}
active_connections_++;
// Handle connection in a new thread
std::thread(&Server::handleConnection, this, client_fd).detach();
}
@@ -486,6 +487,13 @@ private:
error_response.body = R"({"error":"Content-Length too large"})";
return false;
}
// Validate fits in size_t (platform dependent)
if (cl > std::numeric_limits<size_t>::max()) {
error_response.status_code = 413;
error_response.status_text = "Request Entity Too Large";
error_response.body = R"({"error":"Content-Length exceeds platform limit"})";
return false;
}
content_length = static_cast<size_t>(cl);
} catch (...) {
error_response.status_code = 400;