From a061fb3241560d9f357c47d48b48c86643361b06 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 6 Jan 2026 18:42:12 +0000 Subject: [PATCH] Fix additional ESLint warnings and auto-fix issues (56 total warnings fixed) Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com> --- frontends/nextjs/src/app/[tenant]/[package]/layout.tsx | 2 +- frontends/nextjs/src/app/api/v1/[...slug]/route.ts | 4 ++-- frontends/nextjs/src/hooks/auth/auth-store.ts | 10 ++++------ frontends/nextjs/src/hooks/auth/utils/map-user.ts | 6 +++--- .../src/lib/packages/json/render-json-component.tsx | 2 +- 5 files changed, 11 insertions(+), 13 deletions(-) diff --git a/frontends/nextjs/src/app/[tenant]/[package]/layout.tsx b/frontends/nextjs/src/app/[tenant]/[package]/layout.tsx index 720874aa8..b8fa9e0b0 100644 --- a/frontends/nextjs/src/app/[tenant]/[package]/layout.tsx +++ b/frontends/nextjs/src/app/[tenant]/[package]/layout.tsx @@ -27,7 +27,7 @@ interface TenantLayoutProps { */ async function getPackageDependencies(packageId: string): Promise<{ id: string; name?: string }[]> { const metadata = await loadPackageMetadata(packageId) as { dependencies?: string[]; name?: string; minLevel?: number } | null - if (metadata === null || metadata.dependencies === undefined || metadata.dependencies.length === 0) { + if (metadata?.dependencies === undefined || metadata.dependencies.length === 0) { return [] } diff --git a/frontends/nextjs/src/app/api/v1/[...slug]/route.ts b/frontends/nextjs/src/app/api/v1/[...slug]/route.ts index a4ff2b64e..a65e1ac54 100644 --- a/frontends/nextjs/src/app/api/v1/[...slug]/route.ts +++ b/frontends/nextjs/src/app/api/v1/[...slug]/route.ts @@ -125,10 +125,10 @@ async function handleRequest( if (!result.success) { // Map common errors to appropriate status codes const errorMsg = result.error ?? 'Operation failed' - if (errorMsg !== null && errorMsg !== undefined && errorMsg.includes('not found')) { + if (errorMsg?.includes('not found') === true) { return errorResponse(errorMsg, STATUS.NOT_FOUND) } - if (errorMsg !== null && errorMsg !== undefined && errorMsg.includes('required')) { + if (errorMsg?.includes('required') === true) { return errorResponse(errorMsg, STATUS.BAD_REQUEST) } return errorResponse(errorMsg, STATUS.INTERNAL_ERROR) diff --git a/frontends/nextjs/src/hooks/auth/auth-store.ts b/frontends/nextjs/src/hooks/auth/auth-store.ts index fa98e0c09..6af635873 100644 --- a/frontends/nextjs/src/hooks/auth/auth-store.ts +++ b/frontends/nextjs/src/hooks/auth/auth-store.ts @@ -38,11 +38,9 @@ export class AuthStore { } async ensureSessionChecked(): Promise { - if (this.sessionCheckPromise === null) { - this.sessionCheckPromise = this.refresh().finally(() => { - this.sessionCheckPromise = null - }) - } + this.sessionCheckPromise ??= this.refresh().finally(() => { + this.sessionCheckPromise = null + }) return this.sessionCheckPromise } @@ -110,7 +108,7 @@ export class AuthStore { try { const user = await fetchSession() - if (user) { + if (user !== null && user !== undefined) { this.setState({ user: mapUserToAuthUser(user), isAuthenticated: true, diff --git a/frontends/nextjs/src/hooks/auth/utils/map-user.ts b/frontends/nextjs/src/hooks/auth/utils/map-user.ts index 1506b253d..5a22b9639 100644 --- a/frontends/nextjs/src/hooks/auth/utils/map-user.ts +++ b/frontends/nextjs/src/hooks/auth/utils/map-user.ts @@ -18,9 +18,9 @@ export const mapUserToAuthUser = (user: User): AuthUser => { username: user.username, role: user.role as AuthUser['role'], level: getRoleLevel(user.role), - tenantId: user.tenantId || undefined, - profilePicture: user.profilePicture || undefined, - bio: user.bio || undefined, + tenantId: (user.tenantId !== null && user.tenantId.length > 0) ? user.tenantId : undefined, + profilePicture: user.profilePicture ?? undefined, + bio: user.bio ?? undefined, isInstanceOwner: user.isInstanceOwner, } } diff --git a/frontends/nextjs/src/lib/packages/json/render-json-component.tsx b/frontends/nextjs/src/lib/packages/json/render-json-component.tsx index cd48ee37e..a175b0b9e 100644 --- a/frontends/nextjs/src/lib/packages/json/render-json-component.tsx +++ b/frontends/nextjs/src/lib/packages/json/render-json-component.tsx @@ -275,7 +275,7 @@ function evaluateSimpleExpression(expr: string, context: RenderContext): JsonVal if (value !== null && value !== undefined && typeof value === 'object' && !Array.isArray(value)) { value = (value as Record)[innerPart] } - return !value + return value === null || value === undefined || value === false || value === 0 || value === '' ? true : false } // Handle array access or simple property