From 452ea7a785e76a58c3d07ebf4b93b951ae7fab18 Mon Sep 17 00:00:00 2001 From: johndoe6345789 Date: Tue, 10 Mar 2026 21:38:31 +0000 Subject: [PATCH] fix(docker): fail node-deps build if npm install exhausts all retries The retry loop exited with sleep's exit code (0) after all 5 attempts, letting Docker commit an empty /app/node_modules layer. Added explicit exit 1 on the final failed attempt so the build fails visibly instead of producing a broken base image that downstream COPY --from cannot find. Co-Authored-By: Claude Sonnet 4.6 --- deployment/base-images/Dockerfile.node-deps | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/deployment/base-images/Dockerfile.node-deps b/deployment/base-images/Dockerfile.node-deps index d6b513554..d69b61949 100644 --- a/deployment/base-images/Dockerfile.node-deps +++ b/deployment/base-images/Dockerfile.node-deps @@ -56,9 +56,9 @@ RUN npm config set fetch-retries 5 \ && npm config set fetch-retry-mintimeout 20000 \ && npm config set maxsockets 5 \ && for i in 1 2 3 4 5; do \ - npm install 2>&1 \ - && break \ - || (echo "npm install failed (attempt $i/5), retrying in $((i*10))s..." && sleep $((i*10))); \ + npm install 2>&1 && break; \ + [ "$i" = "5" ] && echo "npm install failed after 5 attempts" && exit 1; \ + echo "npm install failed (attempt $i/5), retrying in $((i*10))s..." && sleep $((i*10)); \ done # Pre-install Next.js SWC binaries (avoids unreliable CDN download during