From 25b0fceda8a5d46d6088b08d854a8da24e357f6b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 16 Jan 2026 19:23:10 +0000 Subject: [PATCH] Address code review feedback for JSON test conversions - Fix toHaveAttribute assertions to include expected attribute values (aria-current='page') - Change toBeEnabled to use negated toBeDisabled for semantic correctness - Update TEST_STORY_CONVERSION.md with completion summary Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com> --- TEST_STORY_CONVERSION.md | 28 ++++++++++----------- packages/pagination/playwright/tests.json | 30 +++++++++++++---------- 2 files changed, 31 insertions(+), 27 deletions(-) diff --git a/TEST_STORY_CONVERSION.md b/TEST_STORY_CONVERSION.md index a263bef83..517d5aaf8 100644 --- a/TEST_STORY_CONVERSION.md +++ b/TEST_STORY_CONVERSION.md @@ -139,14 +139,14 @@ export const Default: Story = { ### Can Be Converted (2,500+ lines) - `e2e/smoke.spec.ts` → `packages/smoke_tests/playwright/tests.json` ✅ DONE - `e2e/login.spec.ts` → `packages/auth/playwright/tests.json` ✅ DONE -- `e2e/crud.spec.ts` → Can be converted -- `e2e/navigation.spec.ts` → Can be converted -- `e2e/pagination.spec.ts` → Can be converted -- `e2e/package-loading.spec.ts` → Can be converted -- `e2e/package-rendering.spec.ts` → Can be converted -- `e2e/auth/*.spec.ts` → Can be converted -- `e2e/crud/*.spec.ts` → Can be converted -- `e2e/api/*.spec.ts` → Can be converted +- `e2e/crud.spec.ts` → `packages/crud/playwright/tests.json` ✅ DONE +- `e2e/navigation.spec.ts` → `packages/navigation/playwright/tests.json` ✅ DONE +- `e2e/pagination.spec.ts` → `packages/pagination/playwright/tests.json` ✅ DONE +- `e2e/package-loading.spec.ts` → `packages/package_tests/playwright/tests.json` ✅ DONE +- `e2e/package-rendering.spec.ts` → `packages/package_tests/playwright/tests.json` ✅ DONE +- `e2e/auth/*.spec.ts` → `packages/auth/playwright/tests.json` ✅ DONE +- `e2e/crud/*.spec.ts` → `packages/crud/playwright/tests.json` ✅ DONE +- `e2e/api/*.spec.ts` → `packages/api_tests/playwright/tests.json` ✅ DONE (marked skip - requires request context) ### Should Keep As-Is - `e2e/dbal-daemon/*.spec.ts` - Complex daemon testing @@ -162,9 +162,9 @@ export const Default: Story = { - ✅ `login.spec.ts` (converted) 2. **Medium Priority** - Common workflows - - `crud.spec.ts` - - `navigation.spec.ts` - - `auth/*.spec.ts` + - ✅ `crud.spec.ts` (converted) + - ✅ `navigation.spec.ts` (converted) + - ✅ `auth/*.spec.ts` (converted) 3. **Low Priority** - Complex/specialized tests - `dbal-daemon/*.spec.ts` (keep as TypeScript) @@ -204,10 +204,10 @@ npm run test:e2e ## Summary -- ✅ 2 test suites converted (smoke, auth) -- ✅ 12+ tests now in JSON format +- ✅ 10 test suites converted (smoke, auth, crud, navigation, pagination, api_tests, package_tests) +- ✅ 91+ tests now in JSON format across 6 packages - ✅ JSON runner infrastructure complete - ✅ No code generation - direct interpretation - ✅ Guardrails added to AGENTS.md and CLAUDE.md - ✅ Clean codebase - no junk files -- 🎯 Ready for more conversions as needed +- ✅ All priority test conversions completed diff --git a/packages/pagination/playwright/tests.json b/packages/pagination/playwright/tests.json index 42452714f..f1514b7b6 100644 --- a/packages/pagination/playwright/tests.json +++ b/packages/pagination/playwright/tests.json @@ -73,7 +73,7 @@ "selector": "button[aria-label=\"Go to page 2\"]", "assertion": { "matcher": "toHaveAttribute", - "expected": "aria-current" + "expected": ["aria-current", "page"] } } ] @@ -103,19 +103,21 @@ } }, { - "description": "Next button should be enabled", + "description": "Next button should not be disabled", "action": "expect", "selector": "button[aria-label=\"Go to next page\"]", "assertion": { - "matcher": "toBeEnabled" + "matcher": "toBeDisabled", + "not": true } }, { - "description": "Last button should be enabled", + "description": "Last button should not be disabled", "action": "expect", "selector": "button[aria-label=\"Go to last page\"]", "assertion": { - "matcher": "toBeEnabled" + "matcher": "toBeDisabled", + "not": true } } ] @@ -150,19 +152,21 @@ } }, { - "description": "Previous button should be enabled", + "description": "Previous button should not be disabled", "action": "expect", "selector": "button[aria-label=\"Go to previous page\"]", "assertion": { - "matcher": "toBeEnabled" + "matcher": "toBeDisabled", + "not": true } }, { - "description": "First button should be enabled", + "description": "First button should not be disabled", "action": "expect", "selector": "button[aria-label=\"Go to first page\"]", "assertion": { - "matcher": "toBeEnabled" + "matcher": "toBeDisabled", + "not": true } } ] @@ -261,7 +265,7 @@ "selector": "button[aria-label=\"Go to page 1\"]", "assertion": { "matcher": "toHaveAttribute", - "expected": "aria-current" + "expected": ["aria-current", "page"] } }, { @@ -281,7 +285,7 @@ "selector": "button[aria-label=\"Go to page 2\"]", "assertion": { "matcher": "toHaveAttribute", - "expected": "aria-current" + "expected": ["aria-current", "page"] } }, { @@ -295,7 +299,7 @@ "selector": "button[aria-label=\"Go to page 3\"]", "assertion": { "matcher": "toHaveAttribute", - "expected": "aria-current" + "expected": ["aria-current", "page"] } }, { @@ -319,7 +323,7 @@ "selector": "button[aria-label=\"Go to page 1\"]", "assertion": { "matcher": "toHaveAttribute", - "expected": "aria-current" + "expected": ["aria-current", "page"] } } ]