Address code review feedback: remove redundant boot commands and improve readability

- Remove redundant 'boot' commands from GRUB menu entries (GRUB auto-boots after linux command)
- Split long module list across multiple lines for better readability
- Maintain intentional module duplication for bootstrap safety

Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-31 21:43:34 +00:00
parent bc27b4a094
commit 7e69353ade

View File

@@ -27,7 +27,9 @@ grub-mkstandalone \
--output=/staging/esp/EFI/BOOT/BOOTX64.EFI \
--locales="" \
--fonts="" \
--modules="part_gpt part_msdos fat ext2 normal linux all_video video_bochs video_cirrus gfxterm search search_label search_fs_uuid" \
--modules="part_gpt part_msdos fat ext2 normal linux \
all_video video_bochs video_cirrus gfxterm \
search search_label search_fs_uuid" \
"boot/grub/grub.cfg=/tmp/embedded_grub.cfg"
# Find the kernel
@@ -70,22 +72,16 @@ echo "SparkOS Boot Menu - Starting in \$timeout seconds..."
menuentry "SparkOS" {
echo "Loading SparkOS kernel..."
linux /boot/vmlinuz root=LABEL=$ROOT_LABEL ro init=/sbin/init console=tty0 console=ttyS0,115200n8
echo "Booting..."
boot
}
menuentry "SparkOS (Verbose Mode)" {
echo "Loading SparkOS kernel in verbose mode..."
linux /boot/vmlinuz root=LABEL=$ROOT_LABEL ro init=/sbin/init console=tty0 console=ttyS0,115200n8 debug loglevel=7
echo "Booting in verbose mode..."
boot
}
menuentry "SparkOS (Recovery Mode)" {
echo "Loading SparkOS kernel in recovery mode..."
linux /boot/vmlinuz root=LABEL=$ROOT_LABEL rw init=/bin/sh console=tty0 console=ttyS0,115200n8
echo "Booting into recovery shell..."
boot
}
EOF