From b1b09e90590e9d1b8055cff4f4fd07b8f061acd2 Mon Sep 17 00:00:00 2001
From: johndoe6345789 <john.doe6345789@gmail.com>
Date: Sun, 4 Jan 2026 14:47:08 +0000
Subject: [PATCH] feat: Integrate ILogger into VulkanDeviceService for improved
 logging

---
 src/services/impl/buffer_service.cpp        | 6 +-----
 src/services/impl/vulkan_device_service.cpp | 6 ++++--
 src/services/impl/vulkan_device_service.hpp | 5 ++++-
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/services/impl/buffer_service.cpp b/src/services/impl/buffer_service.cpp
index 7815e57..6df66ec 100644
--- a/src/services/impl/buffer_service.cpp
+++ b/src/services/impl/buffer_service.cpp
@@ -85,6 +85,7 @@ void BufferService::Cleanup() {
 }
 
 void BufferService::Shutdown() noexcept {
+    logger_->TraceFunction(__func__);
     CleanupBuffers();
 }
 
@@ -128,9 +129,4 @@ void BufferService::CleanupBuffers() {
     indexCount_ = 0;
 }
 
-void BufferService::Shutdown() noexcept {
-    logger_->TraceFunction(__func__);
-    CleanupBuffers();
-}
-
 }  // namespace sdl3cpp::services::impl
diff --git a/src/services/impl/vulkan_device_service.cpp b/src/services/impl/vulkan_device_service.cpp
index f739a58..ba8e527 100644
--- a/src/services/impl/vulkan_device_service.cpp
+++ b/src/services/impl/vulkan_device_service.cpp
@@ -1,5 +1,4 @@
 #include "vulkan_device_service.hpp"
-#include "../../logging/logger.hpp"
 #include <SDL3/SDL_vulkan.h>
 #include <iostream>
 #include <set>
@@ -8,6 +7,9 @@
 
 namespace sdl3cpp::services::impl {
 
+VulkanDeviceService::VulkanDeviceService(std::shared_ptr<ILogger> logger)
+    : logger_(logger) {}
+
 VulkanDeviceService::~VulkanDeviceService() {
     if (device_ != VK_NULL_HANDLE) {
         Shutdown();
@@ -16,7 +18,7 @@ VulkanDeviceService::~VulkanDeviceService() {
 
 void VulkanDeviceService::Initialize(const std::vector<const char*>& deviceExtensions,
                                     bool enableValidationLayers) {
-    logging::TraceGuard trace;
+    logger_->TraceFunction(__func__);
 
     deviceExtensions_ = deviceExtensions;
     validationLayersEnabled_ = enableValidationLayers;
diff --git a/src/services/impl/vulkan_device_service.hpp b/src/services/impl/vulkan_device_service.hpp
index 956ed8b..f11b701 100644
--- a/src/services/impl/vulkan_device_service.hpp
+++ b/src/services/impl/vulkan_device_service.hpp
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "../interfaces/i_vulkan_device_service.hpp"
+#include "../interfaces/i_logger.hpp"
 #include "../../di/lifecycle.hpp"
 #include <vector>
 #include <optional>
@@ -16,7 +17,7 @@ namespace sdl3cpp::services::impl {
 class VulkanDeviceService : public IVulkanDeviceService,
                             public di::IShutdownable {
 public:
-    VulkanDeviceService() = default;
+    explicit VulkanDeviceService(std::shared_ptr<ILogger> logger);
     ~VulkanDeviceService() override;
 
     // IVulkanDeviceService interface
@@ -39,6 +40,8 @@ public:
                            VkMemoryPropertyFlags properties) const override;
 
 private:
+    std::shared_ptr<ILogger> logger_;
+
     VkInstance instance_ = VK_NULL_HANDLE;
     VkSurfaceKHR surface_ = VK_NULL_HANDLE;
     VkPhysicalDevice physicalDevice_ = VK_NULL_HANDLE;