From ac35dd42eb2f7cfe82c5f1134f69e77fda99f382 Mon Sep 17 00:00:00 2001
From: johndoe6345789 <john.doe6345789@gmail.com>
Date: Sun, 4 Jan 2026 14:49:17 +0000
Subject: [PATCH] feat: Add ILogger dependency to RenderCommandService for
 improved logging

---
 src/services/impl/render_command_service.cpp | 7 ++++---
 src/services/impl/render_command_service.hpp | 5 ++++-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/services/impl/render_command_service.cpp b/src/services/impl/render_command_service.cpp
index 68c3730..24d333c 100644
--- a/src/services/impl/render_command_service.cpp
+++ b/src/services/impl/render_command_service.cpp
@@ -1,14 +1,15 @@
 #include "render_command_service.hpp"
 #include "../../core/vertex.hpp"
-#include "../../logging/logger.hpp"
 #include <stdexcept>
 
 namespace sdl3cpp::services::impl {
 
 RenderCommandService::RenderCommandService(std::shared_ptr<IVulkanDeviceService> deviceService,
-                                           std::shared_ptr<ISwapchainService> swapchainService)
+                                           std::shared_ptr<ISwapchainService> swapchainService,
+                                           std::shared_ptr<ILogger> logger)
     : deviceService_(std::move(deviceService)),
-      swapchainService_(std::move(swapchainService)) {}
+      swapchainService_(std::move(swapchainService)),
+      logger_(logger) {}
 
 RenderCommandService::~RenderCommandService() {
     if (commandPool_ != VK_NULL_HANDLE || imageAvailableSemaphore_ != VK_NULL_HANDLE) {
diff --git a/src/services/impl/render_command_service.hpp b/src/services/impl/render_command_service.hpp
index 6dd93f8..ce5666a 100644
--- a/src/services/impl/render_command_service.hpp
+++ b/src/services/impl/render_command_service.hpp
@@ -3,6 +3,7 @@
 #include "../interfaces/i_render_command_service.hpp"
 #include "../interfaces/i_vulkan_device_service.hpp"
 #include "../interfaces/i_swapchain_service.hpp"
+#include "../interfaces/i_logger.hpp"
 #include "../../di/lifecycle.hpp"
 #include <memory>
 #include <vector>
@@ -19,7 +20,8 @@ class RenderCommandService : public IRenderCommandService,
                               public di::IShutdownable {
 public:
     explicit RenderCommandService(std::shared_ptr<IVulkanDeviceService> deviceService,
-                                  std::shared_ptr<ISwapchainService> swapchainService);
+                                  std::shared_ptr<ISwapchainService> swapchainService,
+                                  std::shared_ptr<ILogger> logger);
     ~RenderCommandService() override;
 
     // IRenderCommandService interface
@@ -41,6 +43,7 @@ public:
 private:
     std::shared_ptr<IVulkanDeviceService> deviceService_;
     std::shared_ptr<ISwapchainService> swapchainService_;
+    std::shared_ptr<ILogger> logger_;
 
     VkCommandPool commandPool_ = VK_NULL_HANDLE;
     std::vector<VkCommandBuffer> commandBuffers_;