git/GithubWorkflowTool
1
0
Fork 0
mirror of https://github.com/johndoe6345789/GithubWorkflowTool.git synced 2026-04-25 14:15:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix code review issues: matrix parsing, Qt6 compatibility, and performance optimizations

Browse Source 
Co-authored-by: johndoe6345789 <224850594+johndoe6345789@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-27 03:10:27 +00:00
parent a903aae859
commit 18f8bf99b2
6 changed files with 37 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/backends/ContainerBackend.cpp
View File

@@ -26,11 +26,14 @@ bool ContainerBackend::executeStep(const core::WorkflowStep& step,
if (!step.run.isEmpty()) {
QProcess process;
QStringList args;
args << "exec" << m_containerId << "sh" << "-c" << step.run;
// Use specified shell or default to sh
QString shell = step.shell.isEmpty() ? "sh" : step.shell;
args << "exec" << m_containerId << shell << "-c" << step.run;
process.start(m_containerRuntime, args);
if (!process.waitForFinished(300000)) { // 5 minutes
if (!process.waitForFinished(STEP_TIMEOUT_MS)) {
emit error("Step execution timeout");
return false;
}
@@ -61,7 +64,7 @@ bool ContainerBackend::prepareEnvironment(const QString& runsOn) {
process.start(m_containerRuntime, args);
if (!process.waitForFinished(60000)) {
if (!process.waitForFinished(PREPARE_TIMEOUT_MS)) {
emit error("Container creation timeout");
return false;
}
@@ -83,7 +86,7 @@ void ContainerBackend::cleanup() {
args << "rm" << "-f" << m_containerId;
process.start(m_containerRuntime, args);
process.waitForFinished(30000);
process.waitForFinished(CLEANUP_TIMEOUT_MS);
m_containerId.clear();
}